Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Catch 2.9 #1419

Merged
merged 4 commits into from
Jun 17, 2019
Merged

Upgrading to Catch 2.9 #1419

merged 4 commits into from
Jun 17, 2019

Conversation

rolanddenis
Copy link
Member

@rolanddenis rolanddenis commented Jun 16, 2019

PR Description

One more upgrade of Catch to be able to return a value during the benchmarks so that to avoid dead code elimination by the compiler in release mode.

Checklist

  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

From 2.8, in order to be able to return a value in the benchmarks so that to
avoid dead code elimination by the compiler in Release mode.
So that to avoid dead code elimination by the compiler in Release mode.
Also hidding the benchmark to reduce execution time in the test phase.
@dcoeurjo
Copy link
Member

;) 2.9 released 10 hours ago..

(Now I understand the return issue while following the doc)

@rolanddenis
Copy link
Member Author

We are up to date 😆

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. Can you please copy catch 2.9 to  examples\doc-examples ? (which has another copy of catch for the doc.. I don't remember why..)

@rolanddenis
Copy link
Member Author

Done 👍

@dcoeurjo
Copy link
Member

all good thanks

@dcoeurjo dcoeurjo merged commit ee4dc38 into DGtal-team:master Jun 17, 2019
@rolanddenis rolanddenis deleted the pr_catch29 branch June 17, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants